cleanup and fix runtime bugs

iaai_scraper/api/routes/cars.py

@@ -1,4 +1,4 @@
-"""Cars endpoints."""
+# Роуты для просмотра автомобилей и агрегированной статистики.
 
 from fastapi import APIRouter, Depends, HTTPException, Query
 from sqlalchemy import func, select
@@ -6,6 +6,7 @@ from sqlalchemy import func, select
 from ..deps import get_persistence
 from ...storage.db import PersistenceService
 from ...storage.models import Car, Image
+from ...storage.schemas import CarRead
 
 router = APIRouter()
 
@@ -21,7 +22,7 @@ def list_cars(
     is_sold: bool | None = None,
     persistence: PersistenceService = Depends(get_persistence),
 ):
-    """Список автомобилей с пагинацией и фильтрами."""
+    # Список автомобилей с пагинацией и фильтрами
     with persistence.session_scope() as session:
         query = select(Car)
 
@@ -36,11 +37,9 @@ def list_cars(
         if is_sold is not None:
             query = query.where(Car.is_sold == is_sold)
 
-        # Общее количество.
         count_query = select(func.count()).select_from(query.subquery())
         total = session.execute(count_query).scalar() or 0
 
-        # Пагинация.
         offset = (page - 1) * per_page
         cars = session.execute(
             query.order_by(Car.last_seen_at.desc()).offset(offset).limit(per_page)
@@ -51,7 +50,7 @@ def list_cars(
             "page": page,
             "per_page": per_page,
             "pages": (total + per_page - 1) // per_page if per_page else 0,
-            "items": [_car_to_dict(car) for car in cars],
+            "items": [CarRead.model_validate(car).model_dump(mode="json") for car in cars],
         }
 
 
@@ -60,12 +59,12 @@ def get_car(
     car_id: int,
     persistence: PersistenceService = Depends(get_persistence),
 ):
-    """Детальная информация об автомобиле с изображениями."""
+    # Детальная информация об автомобиле с изображениями
     with persistence.session_scope() as session:
         car = session.get(Car, car_id)
         if car is None:
             raise HTTPException(status_code=404, detail="Car not found")
-        return _car_to_dict(car, include_images=True)
+        return CarRead.model_validate(car).model_dump(mode="json")
 
 
 @router.get("/cars/by-origin/{origin_id}")
@@ -73,19 +72,19 @@ def get_car_by_origin(
     origin_id: str,
     persistence: PersistenceService = Depends(get_persistence),
 ):
-    """Поиск автомобиля по origin_id."""
+    # Поиск автомобиля по origin_id
     with persistence.session_scope() as session:
         car = session.execute(
             select(Car).where(Car.origin_id == origin_id)
         ).scalars().first()
         if car is None:
             raise HTTPException(status_code=404, detail="Car not found")
-        return _car_to_dict(car, include_images=True)
+        return CarRead.model_validate(car).model_dump(mode="json")
 
 
 @router.get("/stats")
 def get_stats(persistence: PersistenceService = Depends(get_persistence)):
-    """Общая статистика по БД."""
+    # Общая статистика по БД
     with persistence.session_scope() as session:
         total_cars = session.execute(select(func.count(Car.id))).scalar() or 0
         total_images = session.execute(select(func.count(Image.id))).scalar() or 0
@@ -102,43 +101,3 @@ def get_stats(persistence: PersistenceService = Depends(get_persistence)):
             "top_brands": [{"brand": b, "count": c} for b, c in brands],
         }
 
-
-def _car_to_dict(car: Car, include_images: bool = False) -> dict:
-    """Сериализация Car в dict."""
-    result = {
-        "id": car.id,
-        "parser_id": car.parser_id,
-        "brand": car.brand,
-        "model": car.model,
-        "year": car.year,
-        "price": car.price,
-        "currency": car.currency,
-        "mileage": car.mileage,
-        "country": car.country,
-        "is_sold": car.is_sold,
-        "color": car.color,
-        "drive": car.drive,
-        "gearbox": car.gearbox,
-        "steering_wheel": car.steering_wheel,
-        "body_type": car.body_type,
-        "engine_volume": car.engine_volume,
-        "selling_type": car.selling_type,
-        "origin": car.origin,
-        "origin_url": car.origin_url,
-        "origin_id": car.origin_id,
-        "is_damaged": car.is_damaged,
-        "slug": car.slug,
-        "last_seen_at": car.last_seen_at.isoformat() if car.last_seen_at else None,
-        "content_hash": car.content_hash,
-    }
-    if include_images:
-        result["images"] = [
-            {
-                "id": img.id,
-                "fullres_image": img.fullres_image,
-                "preview_image": img.preview_image,
-                "order_index": img.order_index,
-            }
-            for img in sorted(car.images, key=lambda i: i.order_index)
-        ]
-    return result